Home › Forums › WC Vendors Pro Support › _buy_it_now_price – button doesn't appear after – create auction
NOTICE: We've Moved to a Ticket System for Support
As of August 31, 2017 (12am EST) our support forums will be retired (read-only), and we will be moving to a support ticket system. This will allow us to better organize and answer support requests, and provide a more personalized experience as we assist our customers.
For the time being, we will leave our forums open for reading and learning while we work on creating a more robust Knowledge Base for everyone to use.
If you are a WC Vendors Pro customer please open a support ticket here. If you are a WC Vendors user please open a support ticket on the Wordpress.org forums.
The information on this forum is outdated and in most instances no longer relevant. Please be sure to check our documentation for the most up to date information.
Thank you to all of our customers!
- This topic has 24 replies, 5 voices, and was last updated 7 years, 3 months ago by
konakid.
-
AuthorPosts
-
March 25, 2016 at 5:52 pm #28053
Casper
ParticipantHi,
I’m using WC Vendor Pro and simple auction.
When I create a product with WC Vendor pro from front end, adding all the details (including buy it now price), the buy it now button, doesn’t show up, on the auction.
But when I press the update button in woocommerce backend, on the auction product, the buy it now button appears on front end.
Screenshot link with explaination
Kind regards
Casper Birch
March 25, 2016 at 6:00 pm #28055WC Vendors Support
ParticipantThanks for your report, Casper!
I’ve enabled Simple Auctions and our integration plugin on dev.wcvendors.com — Could you test there as well to see if the problem can be replicated?
March 25, 2016 at 6:35 pm #28066konakid
ParticipantBen, this was one of the issues with Pro and auctions I previously reported to you.
For the benefit of the OP, I had to have a developer custom code a fix for the Buy It Now, along with what you may also find to be issues with altering/configuring/editing the calendar start/end times. You will also find that re-listing auctions is not possible with Pro. And trying to correct, or help vendors, from the backend as Admin, works for somethings, but not others.
Feel free to contact me for some tips if you want. I have been trying to make this work correctly for months now – and am still considering reverting back to the free version – using total backend management.
March 25, 2016 at 6:41 pm #28067WC Vendors Support
ParticipantRelisting works just fine. All relisting does is change the damn start/end date on the auction, and vendors can already do that. 😉
If you’ve got a fix for the buy it now, the plugin is free and open source, your developer can gladly submit a pull request to: https://github.com/wcvendors/wcvendors-pro-simple-auctions
March 25, 2016 at 6:54 pm #28072Casper
ParticipantHi Ben,
Thanks for the quick reply,
I have tried, adding a product as vendor on dev.wcvendors.com, and don’t get any but it now button after creation,
it is this product tried with: Link to product
Best regards
Casper
March 25, 2016 at 8:20 pm #28087konakid
ParticipantBen – re-listing is not that simple. Please understand, re-listing preserves/saves the original item as a finished auction, and recreates a new one with new dates and any changed info. Otherwise, any records associated with the original auction item would be deleted or become intermingled. Vendors may sell the same item over and over again via auction or with Buy It Now – so each instance needs to be preserved/saved separately.
As you suggested —– Just changing the date of a Finished Auction from the Front End only changes the dates for the item in the “My Product List.” A new product does not re-appear in the “Ending Soon Auctions List” and cannot be bid on. The original remains in the “Recently Finished Auction” List as a Finished Auction (with dates unchanged).
But here is a possible solution. Remember when you guys first tried integrating the two plugins using Free? And there wasn’t an Auction Product option available in the Product Data Dropdown in the backend? It is now that way again for Vendors when using Pro. If a Vendor could still access this option in the backend, then he could properly re-list from the backend – using the built-in Re-list option which creates a completely new product listing. I can still do so as Admin – because the dropdown still appears for me and works when re-listing. I could then allow those Vendors who wished to re-list often, access to this backend option.
Can you do anything to make that Auction dropdown in the backend again visible to Vendors in Pro????? If I recall, it was a simple fix to make it available in Free. Then I could at least give those Vendors wishing to re-list often a solution.
March 25, 2016 at 8:32 pm #28091WC Vendors Support
ParticipantWe won’t be working on Simple Auctions (a free, reference template plugin) until we’ve completed building features for Pro. It’s $0. You’ve chosen to pay a third party developer a lot of money to change it for you (instead of even asking us) so you kinda got what you paid for there. I’m pretty sure I’ve mentioned this to you a dozen times in the past already. 🙂 Our priority is to those who purchased and expect Pro features. After that, we have time to work on the freebie stuff, we can then. Custom integrations are always your responsibility — relying on us and paying other people to not getting it to work and failing is no way to go. Free plugins are provided as is, and if an issue exists, we can certainly fix it, but only on our own schedule. We all have kids to feed and a mortgage to pay first.
March 25, 2016 at 8:45 pm #28096konakid
Participant“If you’ve got a fix for the buy it now, the plugin is free and open source, your developer can gladly submit a pull request to: https://github.com/wcvendors/wcvendors-pro-simple-auctions”
I would be more than happy to share any code I have paid for in order to have it integrated into the core. And if I would have known you were available to hire and fix these issues, I would have gladly paid. I no longer have a mortgage and/or kids – been there, done that. 🙂
I am just a simple webmaster. I would be happy to help if I can. But I have no idea what a “pull request” is. Nor have I ever visited github. I didn’t know what services you were prepared to offer – or would have hired you. You seemed to have a full plate, and unavailable for “custom” work – even if it is work that allowed Pro to work with SA – as advertised.
Presently I just know what file(s) the developer has edited, and hopefully what part I need to save and reinsert during upgrades. I have no idea what part(s) of the code was used to fix the Buy It Now. It may have been in WC, SA, the free plugin or all of them. I have had several issues “fixed.”
But if I can help by giving you access to my files, so you could perhaps determine what relates to the Buy It Now, or the Calendar fixes, etc. I will be more than happy to help out.
March 25, 2016 at 8:52 pm #28097WC Vendors Support
ParticipantPull Requests does sound like something out of a foreign movie. Basically, GitHub is a place for storing source code. It allows a team, or even the entire world, the ability to edit and publish code for something. In our case, we use it to develop all of our plugins. Jamie can push new updates to Pro, Free, SA, Stripe, etc, as I can, too. The Simple Auctions repository (repo for short) is here:
https://github.com/wcvendors/wcvendors-pro-simple-auctions
From there, you can create a github account, “fork” the plugin, make your changes, and then send the changes back to the main repository for merging. That’s a lot of information in a single sentence, I know. 🙂 Here’s a YouTube video to get your started learning what it all means:
Granted, this might look like a lot of work for sending in changes — but you’ll use it all the time once you learn how for other plugins, for adding in cool things, fixing typos, and making things better. It’s how the community works with open source software — everyone contributes a little, and everyone wins.
So, get yourself a free github account. Hit the fork button on our repo, and start making changes. When you’re satisfied that your fixes are correct, and you’ve tested them, send in the pull request to merge your changes with the main plugin’s repo, and voila! You’re done, and the next version of SA can be tested for release.
Any questions along the way, just ask.
March 25, 2016 at 11:07 pm #28106Anna
MemberHi there…
@konakid
I am going to be working on the auctions integration soon, so I want to be sure I understand the issue you’ve brought up here:re-listing is not that simple. Please understand, re-listing preserves/saves the original item as a finished auction, and recreates a new one with new dates and any changed info. Otherwise, any records associated with the original auction item would be deleted or become intermingled. Vendors may sell the same item over and over again via auction or with Buy It Now – so each instance needs to be preserved/saved separately.
As you suggested —– Just changing the date of a Finished Auction from the Front End only changes the dates for the item in the “My Product List.” A new product does not re-appear in the “Ending Soon Auctions List” and cannot be bid on. The original remains in the “Recently Finished Auction” List as a Finished Auction (with dates unchanged).
Are you saying that if a vendor wishes to re-list an auction that has ended, and they do so by changing the start/end date, that the “new” or “new-old but now re-listed” auction does not show up as a product in the marketplace that can be bid on?
Sorry if this is a daft question… I just want to be sure I understand correctly so I know what to expect, how to test and/or attempt to make changes if needed.
I think I can deal with the weird buy-it-now issue.. I hope..
ThanksMarch 26, 2016 at 2:10 am #28107konakid
ParticipantHi Anna – that would be great. 🙂 I would be very happy to assist you with these and a few other issues. This is so close to being a great integration. But as is, it has been frustrating my Vendors and me for many months now.
It may be better if we communicated privately, as there are some details that are difficult to express accurately in writing, and then we can “talk” more freely – knowing the world isn’t listening in. 🙂
I would be happy to call and talk on the phone if needed, as well. But, the main problem I think is that until you actually start and list items yourself, have people bid on them, and then finish an auction with the various notices, etc. and/or re-list it, you don’t really get an appreciation for how everything has to work exactly as designed, or else the entire transaction gets off track. This also includes editing products successfully once listed. As it is now, as Admin when trying to help vendors with problems, some backend edits are “fighting” with any front-end edits – especially the calendar start/end times. But I have “fixed” these, and you are welcome to review the code.
Re: the “re-listing” – if you ever used SA with WC Free and re-listed an auction from the backend, then you would understand the way it is supposed to work. There is a special function for it. It is not as simple as changing dates. In addition, re-listing only works for items that have not sold – because there is also an inventory consideration thrown into the equation. Auctions list with an inventory of “1” So if the auction has sold, the inventory drops to zero, and it won’t re-list properly – the inventory has to be adjusted – but doing that from the front end doesn’t work (that may be a SA bug – again, let’s talk privately).
“Are you saying that if a vendor wishes to re-list an auction that has ended, and they do so by changing the start/end date, that the “new” or “new-old but now re-listed” auction does not show up as a product in the marketplace that can be bid on?” YES, THAT IS THE CASE – you have to understand that there are bids, prices, and other data associated with the old auction needs to be saved – even if it doesn’t finish successfully – like not meeting the Reserve Price. So, (the way I think it is designed to work) the old listing stays untouched, intact, and separate. And a new one is created/duplicated with the new dates. Because you can’t keep the original intact, and create a completely new auction listing, by just changing the dates on the original finished auction.
In other words, it appears as if the SA “re-list function” does much more than just change the date. I have a dev site set up if you wish to play with it there. Contact me via PM and we can “talk” via email, Skype, or phone – what ever is most convenient for you. If you tried re-listing in “real time” on a live install – you would understand immediately. I’ll give you the login info if you wish.
March 26, 2016 at 12:16 pm #28121WC Vendors Support
Participantkonakid, you set that as a private reply, so Anna can’t read it. Only Jamie and I can read private replies. 🙂
March 26, 2016 at 2:51 pm #28134konakid
ParticipantThanks Ben – I didn’t want to muck up the forum with any more of my long winded explanations than necessary. 🙂 I’ll send via PM.
March 27, 2016 at 7:08 pm #28208konakid
ParticipantAnd Ben – thanks for the info on Github. You’re right, it does look like a lot of work. It looks to me like the Big Leagues while I am still in the Little League. But I can see why it would be beneficial to understand and use. Hopefully I can eventually make it another tool.
August 13, 2016 at 12:03 pm #39956dave
ParticipantIs this still an issue?
August 13, 2016 at 1:15 pm #39963dave
ParticipantI’ll try and debug it, but it would be good to know if it’s me or something that’s in the code either way:
it’s currently failing on
if ( ! $product->is_purchasable())return;
in..simple_auction/templates/single/product/add-to-cart/auction.php
line 12
i’m going to see if i can find a work around with a wcv_save_product hook
August 13, 2016 at 2:01 pm #39965dave
Participantso far the issue seems to be with the meta value ‘_price’ not being set when saving as an auction. This is usually set when saving an auction in the back end.
Using the following…
add_action('wcv_save_product', 'fix_bid_now_button', 60, 3); function fix_bid_now_button($post_id) { $meta = get_post_meta($post_id); if (isset($meta['_buy_it_now_price']) or !empty($meta['_buy_it_now_price']) ) { update_post_meta($post_id, '_price', $meta['_buy_it_now_price']); return; } }
While this now allows the buy it now button to show, it stops the dashboard from loading the products.
It may just be a simpler fix to override the template for showing the bid now button and do a manual check if worst comes to worst and i cant find a solution to that
I dont know if this is of any use, and i’m still not sure if it’s my end or wc vendors stopping this from being set
August 13, 2016 at 2:41 pm #39966konakid
ParticipantUnfortunately this is apparently still an issue with WCV Pro not integrating well with Simple Auctions. There are several “minor” issues like this that have been unresolved for a long time now. These include the Buy It Now, the Auction Start and End times (hours and minutes conflicts), and the Re-Listing function.
I am unsure of the official status regarding the future of this integration , but the last I heard it was not to be supported or addressed since the software that integrates the two has been offered us for free – and therefore we are on our own. But individual custom fixes have been a nightmare when upgrading or patching WCV and/or SA.
If anyone else who is trying to use Auctions wishes to offer to contribute to a paid supported fix by WCV, that would be included and supported in the core code – maybe if enough of us requested and offered to pay for a working solution – then we could get this working as it should.
August 13, 2016 at 3:44 pm #39969dave
ParticipantI cant for the life of me find the code that generates the dashboard page
August 13, 2016 at 4:43 pm #39972dave
Participantline 151 in class-wcvendorw-pro-table-helper.php is where it falls over
$this->rows = apply_filters( 'wcvendors_pro_table_rows_' . $this->id, $results->posts, $results );
$results, posts and id is set.
Still cant figure out why adding the meta value of _price and _buy_it_now_price causes it to error out here
August 13, 2016 at 5:31 pm #39976dave
ParticipantOkay, i’ve fixed it i think.August 13, 2016 at 5:45 pm #39978dave
ParticipantFixed buy it now not showing
Okay, basically, _price wasnt getting set from vendor dashboard, neither was the _buy_it_now_price. As _price wasnt getting set, it threw an error.
Right, the problem arose when i put a value in it. As there is a multiplication, it requires the value to be forced to an intval, otherwise it throws an error.
anyway, i hope this help someone.
NB: if you are using auctions along side other types of products, you may or may not want to put a check in there for the type of product being saved. as i’m not, i haven’t.
add_action('wcv_save_product', 'fix_buy_it_now', 60, 3); function fix_buy_it_now($post_id) { $meta = get_post_meta($post_id); if( isset($meta['_regular_price']) && !empty($meta['_regular_price']) && $meta['_auction_start_price'] < $meta['_regular_price'] ){ update_post_meta($post_id, '_buy_it_now_price', intval($meta['_regular_price'])); update_post_meta($post_id, '_price', intval( $meta['_regular_price'])); } return; }
just a casual 10 hours of debugging…
August 14, 2016 at 11:20 am #40014Anna
MemberHello,
Guys, please submit a pull request on github so we can get some work going on with this plugin. 🙂
Submit your contribution and we can all work on it.
https://github.com/wcvendors/wcvendors-pro-simple-auctionsOne thing I have noticed… the simple auctions plugin author updates very frequently. This is GOOD, don’t get me wrong.. but the subsequent updates to this plugin now to integrate into the simple auctions/wc vendors will likely need also to have frequent updates.
If we can get a good rapport together on github we can keep working on this plugin to keep it updated and have all of the auction needs properly working.
August 14, 2016 at 5:15 pm #40040dave
ParticipantI’ll need to actually test if this doesnt mess with other things before doing a pull request
August 15, 2016 at 1:18 am #40060konakid
ParticipantThe big test is what happens when someone actually “Buys It Now.”
– Does the auction end as designed?
– And does the shipping, notice, and payment work?Please let us know.
-
AuthorPosts
- The forum ‘WC Vendors Pro Support’ is closed to new topics and replies.